Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divider disappears after create pipeline #1720

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Divider disappears after create pipeline #1720

merged 1 commit into from
Sep 13, 2023

Conversation

dpanshug
Copy link
Contributor

Closes: #1681

Description

This will add a divider between Pipelines and Model serving section.

Screenshot from 2023-08-30 17-42-50

How Has This Been Tested?

  1. Create a Data science project and open it.
  2. Scroll down to Pipelines section.
  3. Assure there is no pipeline.
  4. A divider will exist between Pipeline and Model serving section.

Test Impact

No test require because only adding a divider.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from ed14c90 to 8323422 Compare August 30, 2023 12:36
@dpanshug dpanshug added the do-not-merge/work-in-progress This PR is in WIP state label Sep 1, 2023
@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from 65ff91b to 0e5efb9 Compare September 1, 2023 17:25
@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from deb06e5 to db8e51f Compare September 7, 2023 08:52
@andrewballantyne andrewballantyne added the pr/no-tests-allowed Added by an official approver - this PR is allowed no tests. Omitted, a test must accompany the PR label Sep 7, 2023
@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch 2 times, most recently from 30e99a2 to f67d7a7 Compare September 8, 2023 06:15
@manaswinidas
Copy link
Contributor

manaswinidas commented Sep 8, 2023 •
edited
Loading

@dpanshug Can you squash the commits?

Also, please remove the WIP label in case you're done.

@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from f67d7a7 to 3d5830f Compare September 8, 2023 12:06
@dpanshug dpanshug removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 8, 2023
@dpanshug
Copy link
Contributor Author

dpanshug commented Sep 8, 2023

@dpanshug Can you squash the commits?

Also, please remove the WIP label in case you're done.

@manaswinidas Done 👍

@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from 3d5830f to 4032449 Compare September 11, 2023 09:10
@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from 4032449 to 62edea6 Compare September 12, 2023 12:04
@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from 62edea6 to 40b612e Compare September 12, 2023 14:07
@dpanshug dpanshug force-pushed the 1681-pipeline-divider branch from 40b612e to d92d749 Compare September 13, 2023 07:12
@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 99eeeae into opendatahub-io:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@andrewballantyne andrewballantyne andrewballantyne left review comments

@DaoDaoNoCode DaoDaoNoCode Awaiting requested review from DaoDaoNoCode

@lucferbux lucferbux Awaiting requested review from lucferbux

@manaswinidas manaswinidas Awaiting requested review from manaswinidas

Assignees

@christianvogt christianvogt

@manaswinidas manaswinidas

Labels
approved lgtm pr/no-tests-allowed Added by an official approver - this PR is allowed no tests. Omitted, a test must accompany the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Divider disappears after create pipeline
5 participants
@dpanshug @manaswinidas @christianvogt @andrewballantyne @openshift-merge-robot